Skip to content

iommu: bcm2712-iommu: Add locking; fix address offset; tidy#6939

Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.12.yfrom
njhollinghurst:iommu_20250704
Jul 6, 2025
Merged

iommu: bcm2712-iommu: Add locking; fix address offset; tidy#6939
pelwell merged 1 commit intoraspberrypi:rpi-6.12.yfrom
njhollinghurst:iommu_20250704

Conversation

@njhollinghurst
Copy link
Copy Markdown
Contributor

  • Now using spin_lock_irqsave in map, unmap, sync and iova_to_phys.
  • Simplify bounds checks as all allocations should be in aperture.
  • Use iommu_iotlb_gather_add_range(); NB gather range is inclusive.
  • Fix missing address offset in bcm2712_iommu_sync_all.

- Now using spin_lock_irqsave in map, unmap, sync and iova_to_phys.
- Simplify bounds checks as all allocations should be in aperture.
- Use iommu_iotlb_gather_add_range(); NB gather range is inclusive.
- Fix missing address offset in bcm2712_iommu_sync_all.

Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
@njhollinghurst
Copy link
Copy Markdown
Contributor Author

Briefly tested with rpicam-hello and vlc file.h265 which between them test RP1, ISP-BE/Codec and HVS IOMMUs.

This does not fix any observed bug, but it feels like an improvement. The spin_lock was previously initialized but never used.

@pelwell pelwell merged commit 82924a8 into raspberrypi:rpi-6.12.y Jul 6, 2025
12 checks passed
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jul 7, 2025
kernel: vcsm-cma fixes for lockdep warnings
See: raspberrypi/linux#6929

kernel: dtoverlay: Add autorepeat option to gpio-key overlay
See: raspberrypi/linux#6933

kernel: drivers: media: cfe: Workaround for 16-bit mismatch in the hardware
See: raspberrypi/linux#6935

kernel: configs: Enable more packet classification options
See: raspberrypi/linux#6938

kernel: overlays: ili9881-7inch: Fix overlay name in preamble
See: raspberrypi/linux#6940

kernel: iommu: bcm2712-iommu: Add locking; fix address offset; tidy
See: raspberrypi/linux#6939
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Jul 7, 2025
kernel: vcsm-cma fixes for lockdep warnings
See: raspberrypi/linux#6929

kernel: dtoverlay: Add autorepeat option to gpio-key overlay
See: raspberrypi/linux#6933

kernel: drivers: media: cfe: Workaround for 16-bit mismatch in the hardware
See: raspberrypi/linux#6935

kernel: configs: Enable more packet classification options
See: raspberrypi/linux#6938

kernel: overlays: ili9881-7inch: Fix overlay name in preamble
See: raspberrypi/linux#6940

kernel: iommu: bcm2712-iommu: Add locking; fix address offset; tidy
See: raspberrypi/linux#6939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants